Quiet SSE reconnection logging and improve last_event_id handling #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL::SSL::SSLError with "unexpected eof" occurs when SSE sessions close normally after timeout. Changed to debug level to reduce noise while preserving error logging for actual problems. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Instead of relying on the Last-Event-ID header, pass last_event_id as a parameter to SSE::Client.new. This allows the client library to handle reconnections properly. Only pass a string value when highwater_mark is positive; pass nil for nil or zero values. Updated tests to verify the last_event_id parameter and removed assertions on the Last-Event-ID header. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
last_event_idparameter instead of relying onLast-Event-IDheader for proper reconnection handlinglast_event_idparameter is correctly passed to SSE::ClientDetails
Quieter logging for expected SSE timeouts:
OpenSSL::SSL::SSLErrorwith "unexpected eof" occurs when SSE sessions close normally after timeout (every ~5 minutes). This is expected behavior, so changed from error-level to debug-level logging.Proper last_event_id handling: Pass
last_event_iddirectly toSSE::Client.newso the library can handle reconnections properly. The value is:highwater_markis positivenilwhenhighwater_markisnilor0Test updates: Removed assertions on
Last-Event-IDheader and added new test to verifylast_event_idparameter behavior.🤖 Generated with Claude Code